fix(agent): correct EVM plugin activation condition #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The EVM plugin should be activated when the wallet address starts with '0x'
odilitime
reviewed
Dec 10, 2024
| @@ -392,7 +392,7 @@ export function createAgent( | |||
| : null, | |||
| getSecret(character, "EVM_PRIVATE_KEY") || | |||
| (getSecret(character, "WALLET_PUBLIC_KEY") && | |||
| !getSecret(character, "WALLET_PUBLIC_KEY")?.startsWith("0x")) | |||
| getSecret(character, "WALLET_PUBLIC_KEY")?.startsWith("0x")) | |||
There was a problem hiding this comment.
probably don't need the ?. since getSecret always returns a string
odilitime
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
Bug fix for EVM plugin activation logic
Risks
Low
Background
What does this PR do?
Fixes a logic bug in the EVM plugin activation condition where it was incorrectly checking for wallet addresses that do NOT start with '0x'.
What kind of change is this?
Bug fixes
Documentation changes needed?
Testing
Where should a reviewer start?
Review the change in
agent/src/index.tswhere the EVM plugin activation condition is modified.Detailed testing steps
Code change: