-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set package-manager-strict to false #2873
Conversation
Run & review this pull request in StackBlitz Codeflow. |
✅ Deploy Preview for elk-zone ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for elk-docs canceled.
|
Any issue you encountered with it makes you want to disable it? For me it works fine |
It only happens if you use a pnpm version not matching the exact needed version (not using corepack by the way) |
So why not corepack? In a way I would encourage every contributor to enable corepack (I believe that's also why pnpm add this) |
Why did we allowed it in Vite but not here? This setting does not affect corepack users, but only makes life easier for non corepack users |
8f0a926
to
845afc7
Compare
I don't hold a strong opinion on merging this PR - if the others agree, I think we could move on. But in a way, I think there are true benefits to asking everyone to enable corepack. Otherwise, I'd say it's better to challenge ppm to revert that option with your counterpoints, instead of disabling it manually in every project. Would you agree? |
I did not try to fight yet against pnpm with an issue, but I see nearly in all my related projects that this config was made and so I might report a list to pnpm-repo later on. |
I don't have a strong opinion on this one either side. |
Then lets merge it for now, as it does not have negative effects |
like in vite, set package-manager-strict to false so pnpm v9 can locally be used