Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): disable publish button #3085

Merged
merged 1 commit into from
Dec 14, 2024
Merged

feat(ui): disable publish button #3085

merged 1 commit into from
Dec 14, 2024

Conversation

ayoayco
Copy link
Member

@ayoayco ayoayco commented Dec 13, 2024

This will add disabled attribute to actually disable the publish button when condition is met (e.g., post exceeds server char. limit). Previously we only had aria-disabled.

discovered with issue: #3068

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit 5a8143e
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/675c821508670c000872b071

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit 5a8143e
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/675c8216b728ae0008a19a42
😎 Deploy Preview https://deploy-preview-3085--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ayoayco ayoayco requested a review from shuuji3 December 13, 2024 18:51
@ayoayco ayoayco mentioned this pull request Dec 13, 2024
@ayoayco ayoayco requested a review from userquin December 13, 2024 20:41
@ayoayco ayoayco changed the title feat: disable publish button feat(ui): disable publish button Dec 13, 2024
Copy link
Member

@shuuji3 shuuji3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I never thought this button was clickable😄

@shuuji3 shuuji3 added this pull request to the merge queue Dec 14, 2024
Merged via the queue into main with commit fa6c8a8 Dec 14, 2024
17 checks passed
@shuuji3 shuuji3 deleted the feat/disable-publish-button branch December 14, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants