Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to use explore page for search #3196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shuuji3
Copy link
Member

@shuuji3 shuuji3 commented Feb 8, 2025

resolve #2102

New preference option (enabled in this screenshot but disabled by default)

Screenshot of preference page. new item "Use Explore page for search" exists with checked

Screenshot of Explore page. search input is shown the above of header tab

Screenshot of Explore page searching "#css" shows hashtags and accounts

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit d13bd45
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/67a704670f94ba00081d29cd

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit d13bd45
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/67a70467f83d85000858734b
😎 Deploy Preview https://deploy-preview-3196--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shuuji3
Copy link
Member Author

shuuji3 commented Feb 8, 2025

I'm not sure if this option should be either in "Preference" or "Interface", so just used Preference which is easier to implement. If it should be in "Interface", I feel like other options like "Use star icon" should also be "Interface". 🤔

@patak-dev
Copy link
Member

I think "Preference" is good for this one 👍🏼

@ayoayco ayoayco closed this Feb 9, 2025
@ayoayco ayoayco deleted the shuuji3/feat/use-explore-page-for-search branch February 9, 2025 14:24
@shuuji3 shuuji3 restored the shuuji3/feat/use-explore-page-for-search branch February 9, 2025 14:46
@shuuji3 shuuji3 reopened this Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to add Explore to Search view
3 participants