Cache #3801
Merged
Cache #3801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sources/ElkArte/Cache/CacheMethod/Redis.php
…dis) ! provide a way to fetch the cache object method in use
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #3801 +/- ##
=================================================
+ Coverage 43.49% 43.59% +0.10%
- Complexity 13955 14045 +90
=================================================
Files 348 350 +2
Lines 74966 75199 +233
=================================================
+ Hits 32606 32785 +179
- Misses 42360 42414 +54 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds redis cache support (2) ways
One uses the
phpredispecl extensionOne uses the
predis\predisphp libraryIts up the the admin (site and server) how they want to install those.
peclis straight foward, and in the PR theprediswould have to be placed in theextdirectory. I think moving to full composer vendor directory support is the direction we should move and drop theextdirectory or leave it there just for addons not the core.Still need to add tests