Fix: the gtk expander
widget bugfix
#1132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As it was mentioned in this issue -> #1085, if the
name
property was set for theexpander
widget, then child elements didn't show up. Essentially it was a choice between a labeled but child-freeexpander
or labeless but with childrenexpander
.This behavior came from the
build_builtin_gtk_widget()
function. To be more precise, this function adds child elements only if there aren't any children that have been already added with thewidget_use_to_gtk_widget()
function. The problem with that in this case is thatexpander
's label is actually considered to be a child element itself:So now the
build_gtk_expander()
function handles the child element explicitly (see diff).Fixes #1085
Usage
N/A
Showcase
Here's the minimal configuration used below:
The result:
Works as expected
Additional Notes
Now the
expander
widget is also required to have exactly one child. If no children were provided, there would be an error. I just thought it would be nice, but it can be removed without any problems if necessary.Checklist
Please make sure you can check all the boxes that apply to this PR.
docs/content/main
directory has been adjusted to reflect my changes.cargo fmt
to automatically format all code before committing