Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the gtk libraries to 0.17 #747

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

ettancos
Copy link
Contributor

@ettancos ettancos commented Apr 14, 2023

Updated the gtk related libraries to ~v0.17

This opens the path to use the updated layer-shell protocol to be able to specify keyboard interactivity to be exclusive or on-demand allowing different use-cases on wayland.

Notable changes:

  • v3_22 api is now default
  • glib &Self::Type parameters got removed, object is now in self.obj()
  • glib properties moved to Builders instead of using ::new which is now deprecated, I've used the added helper macros to derive them
  • window::set_wmclass has been removed, according to the docs its redundant so I just removed it

tested on wayland

Maybe some feedback from X users would be welcome just in case.

@VuiMuich
Copy link

So far running well on X11 for me.

@elkowar
Copy link
Owner

elkowar commented Jun 9, 2023

This looks really good! Sorry for the long wait ._.

The only thing I'm not super happy with is removing the wm-class -- while GTK docs rightfully say that it's not a good idea to screw with it in regular applications, for eww (where every widget might "mean" something completely different, even though it's the same application) it does provide lots of value to have each widget be clearly identifiable by the WM and related tooling through the WM class

@elkowar elkowar merged commit 393f7fa into elkowar:master Aug 18, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants