Try to improve performances #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Notes: - avoid allocating an Element when iterating using (*Element).Next() and (*Element).Prev() - avoid allocating an Element when calling (*OrderedMap).Front() and (*OrderedMap).Back() - avoid computing the length of the doubly linked list since it is not strictly needed
Advantages: - no need of (*Element).list field: save both memory and assignations - avoid comparisons in (*Element).Next() and (*Element).Prev(): save time - allow implicit initialization: style - avoid comparisons in (*list).Front() and (*list).Back(): save time - keep almost the same execution time for (*list).Remove(), (*list).PushFront() and (*list).PushBack()
elliotchance
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to improve the performances without altering the API of the package.
The main improvements are:
I guess this PR somehow addresses the concerns expressed in #3 for the v2 version.
benckmarks_pre_PR.txt
benckmarks_post_PR.txt: after commit 1743bc4
benckmarks_post_PR_non_circular_list.txt: after commit 4dccd44
This change is