Allow user to send and recieve custom messages to and from the SMT solver #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
reviewed
Oct 2, 2024
src/context.rs
Outdated
Comment on lines
179
to
195
| /// Directly send a command to the solver. | ||
| pub fn send(&mut self, cmd: SExpr) -> io::Result<()> { | ||
| let solver = self | ||
| .solver | ||
| .as_mut() | ||
| .expect("send requires a running solver"); | ||
| solver.send(&self.arena, cmd) | ||
| } | ||
|
|
||
| /// Directly receive a response from the solver. | ||
| pub fn recv(&mut self) -> io::Result<SExpr> { | ||
| let solver = self | ||
| .solver | ||
| .as_mut() | ||
| .expect("recv requires a running solver"); | ||
| solver.recv(&self.arena) | ||
| } |
There was a problem hiding this comment.
Mind adding a raw_ prefix (or something, open to bikeshedding) and a note in the doc comment to signify that these are low-level, "raw" APIs, check/set_option/etc. should generally be preferred, and are only intended as an escape hatch for solver-specific commands that this crate doesn't have built-in support for?
There was a problem hiding this comment.
Done! I also moved these calls to the bottom of the impl just so that they aren't at the top of cargo doc.
|
Published 0.2.3 with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30