proposing some Hackrf tcp server fix #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ellisgl sorry for latest attempts I wasn't able to align properly from you commit to this one, but now I could! :)
proposing some minor stuff I found during compilation and runtime segmentation faults
the compilation was causing for a missing file and some int evaluations in switch case where the values to evaluate were string, replaced to match with string (coming from the config file)
changed some logic in the evaluation of the if_capcode_valid, I guess it was causing segmentation faults at running time
thanks!! :) Theldus#6