Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix email notification #64

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Fix email notification #64

merged 2 commits into from
Nov 23, 2023

Conversation

devzwf
Copy link
Contributor

@devzwf devzwf commented Nov 23, 2023

as discus in #17 some typo was making email go out with the default from address causing some failure

@devzwf
fix email from field
5192cbc 
in the DB the field is from_email and not fromEmail
@devzwf
name of array case sensitive
3d83298 
fix the use of fromemail for testing the email.
ellite
ellite approved these changes Nov 23, 2023
View reviewed changes
Copy link
Owner

@ellite ellite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ellite ellite merged commit 6e5bbc4 into ellite:main Nov 23, 2023
@devzwf devzwf deleted the Fix-email-notification branch January 23, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellite ellite ellite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devzwf @ellite