Use newer setting from sublime setting #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentience
approved these changes
May 28, 2017
There was a problem hiding this comment.
edit_settings was added in Sublime Text 3 Build 3124. As a result of merging this, I suppose technically we should update the package's listing in Package Control to indicate that it requires this version of Sublime Text or later.
Given, however, that the package would still be quite useful even if this particular command didn't work, I think I'll leave it available to all versions for now.
|
I have never met someone who said: I don't want to update sublime because of a regression. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove compatibility for sublime text 2
I believe we should move on. I think there is several this already using some of the new ST3 api.