Swap ListItems CodeAction

[Strepto]

What have i made?

Related to elm-tooling/elm-language-client-vscode#170

I have made a CodeAction to re-order lists. This action can move a list item up or down in the list, and can be invoked by keyboard shortcuts from your tool of choice.

What is it missing?

• Handle comments
• Ensure handling of non-compiling code
• Add tests
• Refactoring
• (Non fixable?) Move cursor when swapping items, so it can be applied multiple times. (See: Allow CodeActions to specify cursor position microsoft/language-server-protocol#724 )

[Strepto]

The current test is broken, and I cannot figure out how I should fix it. Would like a pointer to figure out how to handle the undefined at this line
TypeError: Cannot read property 'changes' of undefined

elm-language-server/test/codeActionTests/codeActionTestBase.ts

Line 135 in 032707a

codeActions[0].edit!.changes![URI.file(baseUri + uri).toString()],

[razzeee]

Seems like we don't have tooling to test registerRefactorAction yet. The problem is, that you just let the server know which codeActions there are and the actual edit get's created at a later time. But our tests need to do that manually, which we don't do yet. So the call to create the edit instruction never happens right now.

[razzeee]

The new logic isn't perfect, as it should be separated some more, but should be fine for now.

[Strepto]

Thanks! I'll look into improving this when I have some time to spare.

[Strepto]

Thanks for the comments! I'll try working on refactoring next, as I think the logic works better now after I have tested it. Also easier to refactor now that I have some Okish tests!

[razzeee]

I would like to test some cases where a CodeAction should NOT be available. Such as "Move list item up" not being available on the first item. And in this particular test no Move list item should appear.)

Does this seem like something I/we could extend the testCodeAction code with @razzeee ?

Should be possible, we already do this for similar tests (diagnostics), not sure if codeActionTests have the capability yet.

[Strepto]

I have been monitoring microsoft/language-server-protocol#724 for any updates but no news yet.

Without cursor controll I feel this does not yet feel as usable as it should be.

I'll close this for now. But I will reopen or create a new PR once the protocol has this support 🚀.