Skip to content

Personalize MISSING EXPRESSION message #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Conversation

landongrindheim
Copy link
Contributor

Quick Summary:
I encountered this error message when playing around in elm repl. I had to re-read the sentence a couple times to make sure I understood what the compiler was telling me. I hope this small change makes the message just a little easier to understand 😄

I also updated the link to the ContributorAgreement as I encountered a 404 when I decided to submit this change. Let me know if you'd like that to be in a separate pull request 🙂

@landongrindheim
Copy link
Contributor Author

landongrindheim commented Sep 16, 2020

I'm not sure why this is failing the Set Pull Expectation action. I tried this earlier (#2137) and had the same result. If you have insight, please let me know.

Update: I think this is because I'm opening a PR from a fork and don't have write access to this repository.

@evancz
Copy link
Member

evancz commented Feb 3, 2021

Ah, thank you! Much better with that word filled in!

I have learned that the mere act of using GitHub to do contributions has the contributed code fall under the stated license of the project. I think that wasn't as clear legally in the 90s (which is the era of the open source person I initially got my recommendations from) so I need to update files here and there to indicate that we are using the inbound=outbound method for this stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants