Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update packages and frameworks #488

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Update packages and frameworks #488

merged 3 commits into from
Jul 12, 2022

Conversation

marner2
Copy link
Collaborator

@marner2 marner2 commented Jun 22, 2022

Update to .NET 6.0 (LTS) and .NET Framework 4.8 as per Microsoft recommendations. .NET Framework 4.6.1 is out of support and .NET 5.0 is not LTS.

Also updated all packages to latest and consolidated versions.

@marner2 marner2 force-pushed the feature/update_packages_and_frameworks branch 3 times, most recently from b5f1d8b to a2d4d94 Compare June 27, 2022 16:53
@TysonMN
Copy link
Member

TysonMN commented Jul 9, 2022

Update to .NET 6.0 (LTS) [SDK from .NET 5 SDK ...] as per Microsoft recommendations.

Source

This release [of the .NET 5 SDK] has reached end of life, meaning it is no longer supported. We recommend moving to a supported release, such as .NET 6.0.

Update to [...] .NET Framework 4.8 [from .NET 4.6.1] as per Microsoft recommendations.

Source

This release [.NET 4.6.1 runtime] has reached end of life, meaning it is no longer supported. We recommend moving to a supported release, such as .NET Framework 4.8.

TysonMN
TysonMN requested changes Jul 9, 2022
View reviewed changes
src/Elmish.WPF/Elmish.WPF.fsproj Outdated Show resolved Hide resolved
src/Elmish.WPF/Elmish.WPF.fsproj Outdated Show resolved Hide resolved
src/Elmish.WPF/Elmish.WPF.fsproj Outdated Show resolved Hide resolved
src/Samples/Capabilities.Core/Capabilities.Core.fsproj Outdated Show resolved Hide resolved
@TysonMN

This comment was marked as outdated.

Sign in to view
@marner2

This comment was marked as outdated.

Sign in to view
@marner2 marner2 force-pushed the feature/update_packages_and_frameworks branch from a2d4d94 to a938051 Compare July 10, 2022 19:41
@TysonMN

This comment was marked as outdated.

Sign in to view
@TysonMN

This comment was marked as outdated.

Sign in to view
@marner2

This comment was marked as outdated.

Sign in to view
@TysonMN

This comment was marked as outdated.

Sign in to view
@marner2

This comment was marked as outdated.

Sign in to view
@TysonMN TysonMN force-pushed the feature/update_packages_and_frameworks branch from b93c75f to 9734ebd Compare July 12, 2022 11:14
@marner2

This comment was marked as outdated.

Sign in to view
@TysonMN TysonMN merged commit 6079ebc into elmish:master Jul 12, 2022
@marner2 marner2 deleted the feature/update_packages_and_frameworks branch July 12, 2022 18:36
@TysonMN TysonMN mentioned this pull request Jul 22, 2022
Closed
TysonMN
TysonMN reviewed Sep 7, 2022
View reviewed changes
src/Elmish.WPF/Elmish.WPF.fsproj
<PackageReference Update="FSharp.Core" Version="[4.6.2, 99]" />
<PackageReference Update="FSharp.Core" Version="[6.0.5, 99]" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we have to make this change? It is causing a problem described in #509.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were using some of the newer features in some of the code, but I'm sure there are workarounds. I don't remember specifics though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TysonMN TysonMN TysonMN requested changes

@LyndonGingerich LyndonGingerich LyndonGingerich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marner2 @TysonMN @LyndonGingerich