Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change elmocut settings directory to %appdata%\elmocut #53

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Change elmocut settings directory to %appdata%\elmocut #53

merged 1 commit into from
Feb 22, 2023

Conversation

ItsProfessional
Copy link
Contributor

No description provided.

@ItsProfessional ItsProfessional changed the title Change elmocut settings directory to %localappdata%\elmocut Change elmocut settings directory to %appdata%\elmocut Jan 4, 2023
@elmoiv
Copy link
Owner

elmoiv commented Feb 7, 2023

Thank you for the pull request. We also need to check for backward compatibility so that newer versions of elmoCut can move old settings from documents to appdata new location.

elmoiv
elmoiv approved these changes Feb 22, 2023
View reviewed changes
Copy link
Owner

@elmoiv elmoiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve the pull request and add the backward compatibility feature. Thanks for contributing!

@elmoiv elmoiv merged commit c095abe into elmoiv:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LethalAspect LethalAspect LethalAspect approved these changes

@elmoiv elmoiv elmoiv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ItsProfessional @elmoiv @LethalAspect