fix: groups of groupBy should be instance of Collection

eloqjs · Jan 7, 2021 · 0a6c7b2 · 0a6c7b2
1 parent 608ae35
commit 0a6c7b2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/Collection.ts b/src/Collection.ts
@@ -501,14 +501,14 @@ export default class Collection<
    */
   public groupBy<K extends KeyVariadic>(
     key: keyof Item | K | ((item: Item, index: number) => Key)
-  ): Obj<unknown> {
-    const collection: Obj<unknown[]> = {}
+  ): Obj<Collection<Item>> {
+    const collection: Obj<Collection<Item>> = {}
 
     this.items.forEach((item, index) => {
       const resolvedKey: Key = (resolveValue(item, key, index) as Key) ?? ''
 
       if (collection[resolvedKey] === undefined) {
-        collection[resolvedKey] = []
+        collection[resolvedKey] = this.newInstance<Item>([])
       }
 
       collection[resolvedKey].push(item)

diff --git a/tests/methods/groupBy.test.ts b/tests/methods/groupBy.test.ts
@@ -1,4 +1,4 @@
-import { collect } from '../../src'
+import { collect, Collection } from '../../src'
 
 describe('groupBy()', () => {
   const products = [
@@ -14,6 +14,8 @@ describe('groupBy()', () => {
     const grouped = collection.groupBy('manufacturer')
 
     expect(Object.keys(grouped)).toEqual(['IKEA', 'Herman Miller'])
+    expect(grouped['IKEA']).toBeInstanceOf(Collection)
+    expect(grouped['Herman Miller']).toBeInstanceOf(Collection)
     expect(collection).toEqual(products)
   })