Merge pull request #122 from jayantk/delete

Use delete to avoid memory leak
elpheria · Oct 25, 2021 · d5c34c7 · d5c34c7
2 parents 352789c + 6332dc7
commit d5c34c7
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 9 deletions.
diff --git a/build-ts/lib/client.js b/build-ts/lib/client.js
@@ -86,7 +86,7 @@ export default class CommonClient extends EventEmitter {
                 this.queue[rpc_id] = { promise: [resolve, reject] };
                 if (timeout) {
                     this.queue[rpc_id].timeout = setTimeout(() => {
-                        this.queue[rpc_id] = null;
+                        delete this.queue[rpc_id];
                         reject(new Error("reply timeout"));
                     }, timeout);
                 }
@@ -235,7 +235,7 @@ export default class CommonClient extends EventEmitter {
                 this.queue[message.id].promise[1](message.error);
             else
                 this.queue[message.id].promise[0](message.result);
-            this.queue[message.id] = null;
+            delete this.queue[message.id];
         });
         this.socket.addEventListener("error", (error) => this.emit("error", error));
         this.socket.addEventListener("close", ({ code, reason }) => {

diff --git a/dist/index.browser-bundle.js b/dist/index.browser-bundle.js
@@ -228,7 +228,7 @@ var CommonClient = /*#__PURE__*/function (_EventEmitter) {
 
           if (timeout) {
             _this2.queue[rpc_id].timeout = setTimeout(function () {
-              _this2.queue[rpc_id] = null;
+              delete _this2.queue[rpc_id];
               reject(new Error("reply timeout"));
             }, timeout);
           }
@@ -514,7 +514,7 @@ var CommonClient = /*#__PURE__*/function (_EventEmitter) {
         if ("error" in message === "result" in message) _this4.queue[message.id].promise[1](new Error("Server response malformed. Response must include either \"result\"" + " or \"error\", but not both."));
         if (_this4.queue[message.id].timeout) clearTimeout(_this4.queue[message.id].timeout);
         if (message.error) _this4.queue[message.id].promise[1](message.error);else _this4.queue[message.id].promise[0](message.result);
-        _this4.queue[message.id] = null;
+        delete _this4.queue[message.id];
       });
       this.socket.addEventListener("error", function (error) {
         return _this4.emit("error", error);

diff --git a/dist/lib/client.js b/dist/lib/client.js
@@ -168,7 +168,7 @@ var CommonClient = /*#__PURE__*/function (_EventEmitter) {
 
           if (timeout) {
             _this2.queue[rpc_id].timeout = setTimeout(function () {
-              _this2.queue[rpc_id] = null;
+              delete _this2.queue[rpc_id];
               reject(new Error("reply timeout"));
             }, timeout);
           }
@@ -454,7 +454,7 @@ var CommonClient = /*#__PURE__*/function (_EventEmitter) {
         if ("error" in message === "result" in message) _this4.queue[message.id].promise[1](new Error("Server response malformed. Response must include either \"result\"" + " or \"error\", but not both."));
         if (_this4.queue[message.id].timeout) clearTimeout(_this4.queue[message.id].timeout);
         if (message.error) _this4.queue[message.id].promise[1](message.error);else _this4.queue[message.id].promise[0](message.result);
-        _this4.queue[message.id] = null;
+        delete _this4.queue[message.id];
       });
       this.socket.addEventListener("error", function (error) {
         return _this4.emit("error", error);

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/lib/client.ts b/src/lib/client.ts
@@ -166,7 +166,7 @@ export default class CommonClient extends EventEmitter
                 {
                     this.queue[rpc_id].timeout = setTimeout(() =>
                     {
-                        this.queue[rpc_id] = null
+                        delete this.queue[rpc_id]
                         reject(new Error("reply timeout"))
                     }, timeout)
                 }
@@ -363,7 +363,7 @@ export default class CommonClient extends EventEmitter
             else
                 this.queue[message.id].promise[0](message.result)
 
-            this.queue[message.id] = null
+            delete this.queue[message.id]
         })
 
         this.socket.addEventListener("error", (error) => this.emit("error", error))