-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add disableFocusLock prop #234
add disableFocusLock prop #234
Conversation
…ck for function existance.
…r between starting a new step and the 'actionBefore' function completing.
…e-first-step Fix start step actionBefore
…12/reactour into nelsonwong1012-nav-dot-aria-labels
…ialog Add role="dialog" for accessibility
…n_aria_label aria-label option for close button
…edby aria-labelledby
…tion dot for screen reader software
…ia-hidden-combine-a11y-options prop to hide nav from screen readers, combine a11y props
Hello all! What is the status of this? I've seen similar problems. I wanted to open a PR but I can see this was already implemented. Is there a reason for it now being merged? |
Hi @PeterKottas and @bellsml. Hope you understand and thanks you! |
@PeterKottas |
@elrumordelaluz great news indeed! :) @bellsml would you be able to update the PR? Forking and using that is understandably an option but not for the long run. Best to have it in here! Cheers guys ;) |
@PeterKottas @elrumordelaluz Please check if I got it right this time: |
Focuslock component used by Reactour sometimes closes menus, dropdowns and modals, affecting page behavior.