Add UI Support for Controlled Commit States in Elsa Studio #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced the ability to configure commit state behavior for workflows and activities via new UI components and logic. This enhancement allows specifying when workflow state should be committed, improving flexibility and control. Integrated changes across activity property panels and settings to support this feature.
Added specific migration flags to ensure compatibility with updated ReSharper code style settings. This change aims to streamline formatting rules and improve maintainability.
MariusVuscanNx
previously approved these changes
Jan 28, 2025
Replaced MudDialogInstance with IMudDialogInstance to align with the new interface. This improves consistency and ensures compatibility with future updates.
Bumped the base_version from 3.3.1 to 3.3.2 in the packages.yml workflow file. This ensures compatibility with the latest release and updates the build configuration accordingly.
Replaced `ActivityCommitStateBehavior` with a more flexible commit strategy approach utilizing `CommitStrategyDescriptor`. Updated relevant APIs, services, and UI components to support the new model, enhancing configurability and maintainability.
Ensure null-safe access when selecting the commit strategy by adding a null conditional check. This prevents potential runtime issues when a commit strategy name is not present.
Updated the `ToStringFunc` and select item display logic to handle null `DisplayName` values gracefully, defaulting to "-". Also ensured `_selectedCommitStrategy` is updated on selection change to maintain consistency.
Updated the Settings component to initialize and select a commit strategy based on the workflow definition's options. This ensures consistency with other strategy selections and improves functionality in workflow configuration.
Updated string formatting to handle null or whitespace display names more robustly for commit strategies. This ensures proper fallback to "-" when no valid display name is provided.
Replaced project reference with a NuGet package reference for Elsa.Api.Client in Elsa.Studio.Core. Updated ElsaVersion to 3.3.2-preview.2609 to ensure compatibility with the new package version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements the user interface enhancements in Elsa Studio to support the new "Controlled Commit States" feature. It provides users with the ability to configure commit state behaviors for workflows and individual activities directly from the UI.
Feature Overview
Workflow-Level Configuration
Users can now configure commit state options for workflows through a new section in the workflow settings panel. The following options are available:
Multiple options can be selected simultaneously to accommodate different scenarios.
Activity-Level Configuration
Each activity in the workflow designer has been updated with a "Commit State Behavior" dropdown, allowing users to select one of the following options:
Implementation Details
Screenshots
Notes
This PR complements the backend implementation of Controlled Commit States (see issue elsa-workflows/elsa-core#4835). Together, they provide users with comprehensive control over state persistence in workflows.