Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Potential error for missing Retry-After header #362

Closed
vinamogit opened this issue May 22, 2022 · 3 comments
Closed

Potential error for missing Retry-After header #362

vinamogit opened this issue May 22, 2022 · 3 comments
Assignees
Labels

Comments

@vinamogit
Copy link

var retryAfter = int.Parse(response.Headers.GetValues("Retry-After").First());

The Retry-After header is not guaranteed to be sent by the horizon instance, this leads to an unexpected exception in Java implementation, reporting on dotnet for verification.

See lightsail-network/java-stellar-sdk#433

@elucidsoft
Copy link
Owner

I would guess this needs to be changed to FirstOrDefault if that is the case to prevent the exception.

@Kirbyrawr
Copy link
Collaborator

@elucidsoft can you do that please?

@elucidsoft
Copy link
Owner

Yes, will get a commit for this shortly.

@elucidsoft elucidsoft self-assigned this Sep 11, 2022
@elucidsoft elucidsoft added the bug label Sep 11, 2022
elucidsoft pushed a commit that referenced this issue Nov 24, 2022
@Kirbyrawr Kirbyrawr mentioned this issue Nov 25, 2022
4 tasks
elucidsoft added a commit that referenced this issue Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants