[HOTFIX] - User correct OFFSET/LIMIT syntax for MSSQL #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends SELECT query SQL generation for MSSQL so that the correct syntax is used when a query is built with the
->limit()or->offset()methods. Standard SQL does not work and clause of the formOFFSET n ROWS FETCH NEXT n ROWS ONLYmust be used instead.Because these clauses were being generated directly in the
Tableclass when the corresponding methods are called, the responsibility has been extract intoDriver/Base::getLimitClause(). A default implementation exists here, mirroring the existing functionality for all drivers, and a special implementation has been added via an override inDriver/Mssql.Closes #24.