Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown menus #184

Open
xiaq opened this issue Apr 19, 2016 · 1 comment
Open

Dropdown menus #184

xiaq opened this issue Apr 19, 2016 · 1 comment
Labels

Comments

@xiaq
Copy link
Member

xiaq commented Apr 19, 2016

This is inspired by ptpython, whose completion menu looks better than that of elvish (which is modeled after zsh):

ptpython dropdown menu

The "dropdown" feeling can be attributed to two factors: a different background color, and margins on the sides.

xiaq added a commit that referenced this issue Oct 3, 2016
@xiaq xiaq mentioned this issue Jan 14, 2017
@xiaq xiaq added the maybe label Mar 8, 2018
@xiaq xiaq changed the title Give listings a "dropdown menu" feeling Dropdown menus Dec 27, 2019
@krader1961
Copy link
Contributor

FWIW, I didn't know about ptpython until I looked at that project in response to reading this issue. So thanks for bringing that project to my attention. Nonetheless, I don't think this issue has sufficient information to drive a change in the existing elvish behavior. Especially since four years have elapsed since this issue was opened and a lot has changed in that interval. The example in the problem statement produces decent, if different, output in a current elvish version. Could the output be better? Probably, but who gets to decide which is better? At the end of the day a lot of issues like this one require reasonable defaults plus the ability of the user to tweak it to suit their needs. Which seems to be loosely related to issue #1001.

@xiaq xiaq removed the A:Editor label Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants