Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-sinon-qunit is incompatible with ember-qunit 8.0.1 #885

Closed
lozjackson opened this issue Sep 27, 2023 · 9 comments
Closed

ember-sinon-qunit is incompatible with ember-qunit 8.0.1 #885

lozjackson opened this issue Sep 27, 2023 · 9 comments

Comments

@lozjackson
Copy link

after upgrading ember-qunit to 8.0.1 I get the following error when trying to run the tests for our app

Uncaught Error: QUnit has already been defined.

I've tried reproducing this in a fresh ember app - ember-qunit 8.0.1 works until I installed ember-sinon-qunit (7.1.4).

@lozjackson lozjackson changed the title ember-winon-qunit is incompatible with ember-qunit 8.0.1 ember-sinon-qunit is incompatible with ember-qunit 8.0.1 Sep 27, 2023
@SergeAstapov
Copy link
Collaborator

@lozjackson @elwayman02 I bet this is caused by #891

elwayman02 added a commit to elwayman02/ember-resize-modifier that referenced this issue Oct 11, 2023
via ember-cli-update

* Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
elwayman02 added a commit to elwayman02/ember-resize-modifier that referenced this issue Oct 11, 2023
via ember-cli-update

* Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
elwayman02 added a commit to elwayman02/ember-scroll-modifiers that referenced this issue Oct 11, 2023
via ember-cli-update

* Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
elwayman02 added a commit to elwayman02/ember-resize-modifier that referenced this issue Oct 11, 2023
via ember-cli-update

* Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
@ndekeister-us
Copy link

ndekeister-us commented Oct 31, 2023

Had same error when migrating to Ember 5, which install ember-qunit v8

Created #914 which solved the issue on my side, didn't investigated deeper on why we have this error now

@elwayman02
Copy link
Owner

#908 and #905 appear to have fixed the problem, but we'll keep this ticket open until the next release so we can confirm the issue is resolved.

@Techn1x
Copy link
Contributor

Techn1x commented Nov 1, 2023

can't wait!! thanks for the hard work

@elwayman02
Copy link
Owner

Please test 7.4.0 and let me know if the issue is resolved!

@ndekeister-us
Copy link

7.4.0 fixed the issue on my side, tests are running when we use it with ember-qunit@8

Thanks 🎉

@elwayman02
Copy link
Owner

That's fantastic! Great work, everyone.

@lozjackson
Copy link
Author

can confirm the issue is fixed for me after upgrading to 7.4.0.

Thanks

@IgnaceMaes
Copy link

Just in case anyone else stumbled upon this issue from Google search: I was still seeing this issue after upgrading to 7.4.0.

After a long search, it turns out there was one test file located inside of the app folder. This caused qunit to be imported by ember-auto-import. Moving that to the test folder fixed the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants