-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember-sinon-qunit is incompatible with ember-qunit 8.0.1 #885
Comments
@lozjackson @elwayman02 I bet this is caused by #891 |
via ember-cli-update * Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
via ember-cli-update * Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
via ember-cli-update * Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
via ember-cli-update * Skip ember-qunit v8 for now due to elwayman02/ember-sinon-qunit#885
Had same error when migrating to Ember 5, which install Created #914 which solved the issue on my side, didn't investigated deeper on why we have this error now |
can't wait!! thanks for the hard work |
Please test 7.4.0 and let me know if the issue is resolved! |
7.4.0 fixed the issue on my side, tests are running when we use it with ember-qunit@8 Thanks 🎉 |
That's fantastic! Great work, everyone. |
can confirm the issue is fixed for me after upgrading to 7.4.0. Thanks |
Just in case anyone else stumbled upon this issue from Google search: I was still seeing this issue after upgrading to 7.4.0. After a long search, it turns out there was one test file located inside of the |
after upgrading ember-qunit to 8.0.1 I get the following error when trying to run the tests for our app
I've tried reproducing this in a fresh ember app - ember-qunit 8.0.1 works until I installed ember-sinon-qunit (7.1.4).
The text was updated successfully, but these errors were encountered: