Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ignore empty files #150

Closed
2 tasks done
elycruz opened this issue Jul 24, 2024 · 0 comments · Fixed by #153
Closed
2 tasks done

Fix: Ignore empty files #150

elycruz opened this issue Jul 24, 2024 · 0 comments · Fixed by #153
Assignees
@elycruz
Labels
bug enhancement good first issue

Comments

@elycruz
Copy link
Owner

elycruz commented Jul 24, 2024 •
edited
Loading

Currently the render response processor method doesn't return a promise for the case where a matched styling file is empty.

Reported in: #149 .

Acceptance Criteria

  • Make sure an empty promise is returned for the above mentioned case.
  • Ensure we have a test case covering this case.
@elycruz elycruz self-assigned this Jul 24, 2024
@elycruz elycruz mentioned this issue Jul 24, 2024
Closed
elycruz added a commit that referenced this issue Aug 7, 2024
@elycruz
feat: issue-#150 - ignore empty files
3c5829c 
- Scaffolding for feature
  and tests.
elycruz added a commit that referenced this issue Aug 18, 2024
@elycruz
feat: issue-#150 - Ignore empty files and css file support
81855f3 
- Cleaned up related fixtures.
- Updated 'watch' feature tests to also include
  'empty files' case promise test.
elycruz added a commit that referenced this issue Aug 18, 2024
@elycruz
feat: issue-#150 - Ignore empty files and css file support
d8058ab 
- Removed partial support for *.css
  file includes - whatever
  dart-sass/node-sass handles
  via their functionality will
  be handled by them.
@elycruz elycruz mentioned this issue Aug 18, 2024
Merged
elycruz added a commit that referenced this issue Aug 18, 2024
@elycruz
Merge pull request #153 from elycruz/fix/issue-#150/empty_style_files
5863042 
Fix/issue #150/ignore empty style files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elycruz elycruz

Labels
bug enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/issue #150/empty style files elycruz/rollup-plugin-sass
1 participant
@elycruz