Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps-dev): update typescript to 5.5.4 and enable strict mode #156

Merged
merged 1 commit into from
Sep 24, 2024
Merged

chore(deps-dev): update typescript to 5.5.4 and enable strict mode #156

merged 1 commit into from
Sep 24, 2024

Conversation

marcalexiei
Copy link
Collaborator

@marcalexiei marcalexiei commented Aug 22, 2024 •
edited
Loading

Before adding ESLint I would like to update typescript to version 5.5.

  • typescript update to v5.5.4
  • enabled typescript strict mode which results in
    • improvements on insertStyle
    • type refinements on source code (runtime code should not be affected)

marcalexiei
marcalexiei commented Aug 22, 2024
View reviewed changes
package.json Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
tsconfig.json Show resolved Hide resolved
test/insertStyle.test.ts Show resolved Hide resolved
@marcalexiei marcalexiei marked this pull request as ready for review August 22, 2024 08:35
@marcalexiei marcalexiei mentioned this pull request Aug 22, 2024
Open
7 tasks
@marcalexiei
Copy link
Collaborator Author

@elycruz when you have the chance, could you please review this PR?

@marcalexiei marcalexiei mentioned this pull request Sep 18, 2024
Open
@elycruz
Copy link
Owner

elycruz commented Sep 20, 2024

Hey @marcalexiei , will do - ETA this weekend.

@elycruz elycruz changed the base branch from main to dev September 24, 2024 16:53
@elycruz elycruz changed the base branch from dev to main September 24, 2024 16:55
@elycruz elycruz merged commit e8801aa into elycruz:main Sep 24, 2024
1 check passed
@elycruz
Copy link
Owner

elycruz commented Sep 24, 2024

Changes are good (👍 ) (thx @marcalexiei ).

@marcalexiei marcalexiei deleted the feature/ts branch September 25, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elycruz elycruz elycruz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marcalexiei @elycruz