-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1155 Support node version 16.x in elyra-canvas #1156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to update the 2 build files from 14.x to 16.x under https://github.com/elyra-ai/canvas/tree/main/.github/workflows.
There was also a change in npm 8 where in the publish cmd you'll need to reference the config file.
npm publish --userconfig=~/.npmrc
@matthoward366 Following step failed -
Producing broken (bad CRC) zip archives on Node v15.6.0 is a known issue fixed in crc32-stream.
|
@nmgokhale You can remove the code for this since it's not actually used anymore and doesn't work for Cypress. |
echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}" > .npmrc | ||
npm publish | ||
echo "//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}" > ~/.npmrc | ||
npm publish --userconfig=~/.npmrc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure but I think we also need --registry here. This is what I ran into with another repo.
Fixes #1155 and #1132
Developer's Certificate of Origin 1.1