Remove unnecessary extra code

Signed-off-by: Martha Cryan <Martha.Cryan@ibm.com>
elyra-ai · Jan 4, 2023 · 4b5e50a · 4b5e50a
1 parent ac240b8
commit 4b5e50a
Showing 1 changed file with 1 addition and 9 deletions.
diff --git a/packages/ui-components/src/FormDialog.tsx b/packages/ui-components/src/FormDialog.tsx
@@ -58,10 +58,7 @@ export const showFormDialog = async (
       dialogBody.node
         .querySelectorAll('select, input, textarea')
         .forEach((element: any) => {
-          if (
-            element.hasAttribute('data-form-required') ||
-            element.type === 'number'
-          ) {
+          if (element.hasAttribute('data-form-required')) {
             const elementTagName = element.tagName.toLowerCase();
 
             if (elementTagName === 'select' || element.type === 'number') {
@@ -135,11 +132,6 @@ const preventDefaultDialogHandler = (
 
 // Returns true if given element is valid
 const isFieldValid = (element: any): boolean => {
-  if (element.type === 'number') {
-    return element.hasAttribute('data-form-required')
-      ? element.value !== ''
-      : true;
-  }
   return element.value.trim() ? true : false;
 };