Skip to content

Commit

Permalink
Do not persist the jupyter baseUrl in pipelines (#2775)
Browse files Browse the repository at this point in the history
The changes in #2728 cause the pipeline-editor to persist the full
url for a node's image. This could cause issues with surfacing PI,
as such I've updated that fix to instead use the full URL base,
which will behave the same as before the fix, but including the
URL path from the baseUrl if one exists.

Note that if a baseUrl path conatains PI that would still be
persisted, but puting PI in a URL path is considered inappropriate
handling of PI by the server owner, not Elyra.

Fixes #2773
  • Loading branch information
ajbozarth authored Jun 9, 2022
1 parent 96a9005 commit ad8f993
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions packages/pipeline-editor/src/pipeline-hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -213,10 +213,9 @@ export const componentFetcher = async (type: string): Promise<any> => {
category.node_types?.[0]?.runtime_type ?? 'LOCAL';

const type = types.find((t: any) => t.id === category_runtime_type);
const defaultIcon = URLExt.join(
ServerConnection.makeSettings().baseUrl,
type?.icon || ''
);
const defaultIcon = URLExt.parse(
URLExt.join(ServerConnection.makeSettings().baseUrl, type?.icon || '')
).pathname;

category.image = defaultIcon;

Expand Down

0 comments on commit ad8f993

Please sign in to comment.