-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JSON viewer for .pipeline files #1943
Comments
@ajbozarth - thoughts? |
As I mentioned in the dev meeting I took a swing at addressing this sometime last year and actually spent some time on it. The options that are show in the context menu are determined by the widget factories. When a widget factory is created it lists the file types that it supports, which would then list that widget as an option in the context menu for that file type. In this case the JSON extension in core creates the factory and sets the file types (json and notebook). File types are separately defined in the doc registry. In pipeline-editor-extension we add the pipeline file type for To add pipeline files to the JSON factory we would need to add it in core JL. If Another option would be to "override" the JSON factory by removing it and then adding an extension that "extends" it ourselves with the pipeline file type support, but the JSON editor does not seem easily extendable to do so. As my extensive work on this is well over a year old things might have changed on the JL core side that would more easily allow this feature add though if someone else wants to take the time to look into it again. |
Leaving a note here, it seems the Doc Registry can now be extended, so we "may" be able to implement the "override" idea at the docRegistry level instead. Not sure if it would be useful but I'll make note of this here jupyterlab/jupyterlab#10256 |
IIUC jupyterlab/jupyterlab#11540 has added support for this. Once that is released we'll be able to add this support. As such moving this to the 4.0 sprint (with the assumption that it will be release in lab 4) |
Once #2495 is merged this should be pretty trial for me to fix |
Pipieline files can currently be opened in either the pipeline editor or the file editor. This uodate also allows users to open pipeline files with the JSON viewer. Fixes elyra-ai#1943
Pipieline files can currently be opened in either the pipeline editor or the file editor. This uodate also allows users to open pipeline files with the JSON viewer. Fixes #1943
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Currently
.pipeline
files can only be opened in the VPE or the plain text editor from the File Browser context menu:Describe the solution you'd like
Enable the JSON viewer (like it is for Jupyter notebooks) to make it easier to browse the file:
![image](https://user-images.githubusercontent.com/13068832/126681712-46de380a-5229-4f9e-aff4-9517e18aee72.png)
The text was updated successfully, but these errors were encountered: