Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing material ui packages #2948

Closed
kevin-bates opened this issue Oct 4, 2022 · 4 comments · Fixed by #2955
Closed

Look into removing material ui packages #2948

kevin-bates opened this issue Oct 4, 2022 · 4 comments · Fixed by #2955

Comments

@kevin-bates
Copy link
Member

Users running in hosted environments with slower network latencies are experiencing Elyra startup delays that may be due to the lack of material ui packaging optimization. We should understand where these costs are occurring and only packaging what is absolutely necessary for the proper functioning of Elyra.

@ajbozarth
Copy link
Member

We currently still use Material UI in three places:

  1. Toast notifications in pipeline-editor
  2. Theme Provider in ui-components
  3. The Metadata Header UI in metadata-common

As for removing these:

  1. Toast notifications are being added to core in 4.0, we can either wait or directly use the library they are merging into core (I believe it's not new code)
  2. We already wanted to remove StyleProvider, so we can see how much we leverage ThemeProvider vs just generically wrap it ourselves
  3. This will be the hardest since all the header functionality uses material ui and we will need to rewrite it

@jschaeck
Copy link

jschaeck commented Oct 4, 2022

Not sure if this helps at all but material ui have some proposals how to minimize component size, maybe this could help to improve the situation till it is completely removed?

https://mui.com/material-ui/guides/minimizing-bundle-size/

@ptitzler
Copy link
Member

ptitzler commented Oct 5, 2022

We currently still use Material UI in three places:

  1. Toast notifications in pipeline-editor
  2. Theme Provider in ui-components
  3. The Metadata Header UI in metadata-common

We've discussed this in today's dev meeting:

@ptitzler
Copy link
Member

ptitzler commented Oct 5, 2022

@jschaeck please subscribe to those issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants