-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Material UI ThemeProvider and Metadata header #2955
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
@ajbozarth Thanks for catching those - I fixed the color of the palette categories but I checked and the icon colors are unrelated to my changes and if I'm remembering correctly, we did look into them and it was a canvas issue. We could make a separate issue for that but it's not actually straightforward to fix. |
- Replaced snackbar with toastify - Fixed dark mode color for some icons
I've push some updates including:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marthacryan aside from the minor fixed I added, your code changes look solid and the UX is great when run locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #2951 - removes the use of ThemeProvider and other material UI components to remove material UI from imports.
Mostly maintains the same UI, but the main change is that it now uses the built-in context menu's from JupyterLab for the metadata header:
Fixes #2948
Fixes #2952
Developer's Certificate of Origin 1.1