Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Material UI ThemeProvider and Metadata header #2955

Merged
merged 5 commits into from
Oct 11, 2022

Conversation

marthacryan
Copy link
Member

@marthacryan marthacryan commented Oct 5, 2022

Fixes #2951 - removes the use of ThemeProvider and other material UI components to remove material UI from imports.

Mostly maintains the same UI, but the main change is that it now uses the built-in context menu's from JupyterLab for the metadata header:
image

Fixes #2948
Fixes #2952

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Oct 5, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added this to the 3.13.0 milestone Oct 5, 2022
@ajbozarth
Copy link
Member

on a quick check there are a few things not changing when using dark mode:

category name & arrow icon:
Screen Shot 2022-10-06 at 12 47 52 PM

icons for arrange buttons:
Screen Shot 2022-10-06 at 12 48 13 PM

There also some issues in the metadata header but we're replacing that so no work needed there

@marthacryan marthacryan changed the title Remove Material UI ThemeProvider Remove Material UI ThemeProvider and Metadata header Oct 6, 2022
@marthacryan
Copy link
Member Author

@ajbozarth Thanks for catching those - I fixed the color of the palette categories but I checked and the icon colors are unrelated to my changes and if I'm remembering correctly, we did look into them and it was a canvas issue. We could make a separate issue for that but it's not actually straightforward to fix.

- Replaced snackbar with toastify
- Fixed dark mode color for some icons
@ajbozarth
Copy link
Member

I've push some updates including:

  • I fixed the icon coloring I mentioned above (overrode it with css )
    Screen Shot 2022-10-06 at 5 56 14 PM
    Screen Shot 2022-10-06 at 5 56 18 PM
  • I tinkered with the css classes on the header buttons, previously the context menu was added for both buttons so if you right clicked either the add or refresh it showed the add menu, I made it only show on the add button.
    Screen Shot 2022-10-06 at 6 04 52 PM
  • I removed the final Material UI dependency from pipeline editor by replacing the SnackBar Alert with a ToastContainer provided by https://github.com/fkhadra/react-toastify (the library core will be using in 4.0)
    Screen Shot 2022-10-06 at 6 07 45 PM
    • Some change in toast functionality:
      • clicking outside the notification no longer clears it (this is not natively supported by toastify, but if it's an issue we can write our own handler to do it)
      • multiple toast notification stack rather than replace the current one

Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marthacryan aside from the minor fixed I added, your code changes look solid and the UX is great when run locally

@marthacryan marthacryan marked this pull request as ready for review October 7, 2022 15:33
Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 797a17b into elyra-ai:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants