Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent dependency caps #2431

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

kiersten-stokes
Copy link
Member

Closes #2430

What changes were proposed in this pull request?

Removes the cap for:

  • jupyter_core (former cap on v5 was unnecessary as Elyra works close enough with this repo to be aware of breaking changes)

  • minio (former cap on v8 didn't exist)

  • pyyaml (former cap on v6 should not introduce any breaking changes; tested and confirmed)

  • requests (former cap on v3 didn't exist; future releases, however, may include breaking changes)

How was this pull request tested?

Tests are passing. Also manually tested to ensure that pyyaml v6 has the expected behavior.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Feb 1, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks.

@akchinSTC akchinSTC merged commit 2bbdde9 into elyra-ai:master Feb 2, 2022
@lresende lresende added this to the 3.6.0 milestone Feb 17, 2022
@kiersten-stokes kiersten-stokes deleted the dependency-fixes branch April 1, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix unnecessary dependency caps
5 participants