-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata editor to use JupyterLab's new form editor #2464
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments on the code changes since my last review, and I'm building this to test locally atm
packages/ui-components/src/FormComponents/MetadataEditorTags.tsx
Outdated
Show resolved
Hide resolved
UI/UX Review as mentioned above, all tested in Safari:
Screen.Recording.2022-05-23.at.4.13.14.PM.mov
That's all I found on an initial pass, I only played with it for less than an hour |
Yeah this is the current behavior so I figured it was the UX we wanted, but I could see that being a little annoying. If @ptitzler has an opinion let us know!
Fixed
I'm not able to reproduce this? Maybe we can do a call to debug
Fixed
Fixed misalignment of tooltips and added tooltip to code field. I don't think tags already had that so not sure if I should add that in?
Fixed the spacing up a little, let me know if you have more input on the style
Fixed |
It appears that for list-valued properties there are two new buttons displayed (move up, move down) that appear to give the user the ability to reorder list items. Is this something that could be disabled? While there might be general use cases where order matters, I can't think of one for any of our properties. Part of the problem is that the list-specific action buttons are rendered in a way that feels too attention grabbing, considering that they don't serve a practical purpose. The old/existing rendering (shown here for a list-valued pipeline property) of list-specific blends in nicely and doesn't require additional screen real estate: |
Ageneral observation that the current styling appears to use almost always bold fonts (section headers, property labels, ...) as shown here for runtime configurations: As a result everything seems to blend in, eliminating the benefits, for example, of section headers that were meant to help the user put labels into proper context. For comparison, here's the current rendering, which is a lot less attention grabbing: |
Thanks @ptitzler! think I addressed all of those points. I also added those two password fields that hadn't been updated to be detected yet so all the password fields should be working now. I also added the tooltips over an info icon: This tooltip shows up when the mouse is hovering over the "?" icon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, I gave @marthacryan a couple UI tweaks to follow up on over a Webex that I would consider non-blocking
This PR adds the package rjsf(react JSON schema form - a renderer for showing JSON schema as a form) to the metadata editor for consistency with JupyterLab (moved to using this package in the most recent release with jupyterlab/jupyterlab#11079. Going forward, this will also handle many of the more complex cases for rendering the metadata editor and provide built-in features that will solves issues such as #2269 and #2268.
Screenshots / gifs to come
Todo:
- [ ] Update documentationFollow up PR to comeDeveloper's Certificate of Origin 1.1