Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version requirement for nbformat, ipython, and traitlets #2493

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Bump version requirement for nbformat, ipython, and traitlets #2493

merged 4 commits into from
Feb 18, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Feb 18, 2022

Fixes #2491 for notebook pipelines running on KFP and Airflow

What changes were proposed in this pull request?

How was this pull request tested?

Ran NOAA pipeline on KFP and AA.

To test:

  • Configure Elyra to use
    $ export ELYRA_GITHUB_BRANCH=i2491-fix
    $ export ELYRA_GITHUB_ORG=ptitzler
    $ jupyter lab
    
  • Create and run notebook pipelines on KFP and Airflow

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Feb 18, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

 ¯\_(ツ)_/¯
@ptitzler ptitzler added the kind:bug Something isn't working label Feb 18, 2022
@ptitzler ptitzler added this to the 3.7.0 milestone Feb 18, 2022
@ptitzler ptitzler added component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Feb 18, 2022
@ptitzler
Copy link
Member Author

Pinning nbformat to 5.1.3 results in

from traitlets.utils import filefind
ImportError: cannot import name 'filefind' from 'traitlets.utils

@ptitzler ptitzler changed the title Bump version requirement for nbformat Bump version requirement for nbformat, ipython, and traitlets Feb 18, 2022
@ptitzler ptitzler removed the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Feb 18, 2022
Copy link
Member

@akchinSTC akchinSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified on kfp and aa runtimes

@akchinSTC akchinSTC merged commit a76e6c3 into elyra-ai:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notebook pipelines are failing on KFP and Airflow
3 participants