Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid KFP component URL references #2503

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Fix invalid KFP component URL references #2503

merged 1 commit into from
Feb 25, 2022

Conversation

ptitzler
Copy link
Member

Closes #2502

What changes were proposed in this pull request?

Update all invalid GitHug resource URL with a valid one.

How was this pull request tested?

Reviewed the output of make docs and confirmed that the displayed GitHub URLs are valid

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:bug Something isn't working area:documentation Improvements or additions to documentation labels Feb 25, 2022
@elyra-bot
Copy link

elyra-bot bot commented Feb 25, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added this to the 3.7.0 milestone Feb 25, 2022
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Links are working

@lresende
Copy link
Member

Why do we have airflow in the main repo, and kfp is in the example one?

@ptitzler
Copy link
Member Author

Why do we have airflow in the main repo, and kfp is in the example one?

Not sure I understand your question. The documentation contained example CLI invocations that include references to KFP example component definitions. In older releases those component definitions used to live in the elyra repo, but they no longer do. The same is true for Airflow. All example components are stored in https://github.com/elyra-ai/examples/tree/master/component-catalog-connectors. This PR only updates the incorrect links.

@akchinSTC akchinSTC merged commit 6b1c4b5 into elyra-ai:master Feb 25, 2022
@ptitzler ptitzler deleted the i2502 branch February 28, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline component documentation examples reference non existing assets
4 participants