Sanitize KFP input/output params in kwargs

[thesuperzapper]

What changes were proposed in this pull request?

This PR prevents Elyra from throwing an error when it tries to pass invalid kwargs to a KFP component-factory function.

Traceback (most recent call last):
  File "/opt/conda/lib/python3.8/site-packages/elyra/pipeline/kfp/processor_kfp.py", line 622, in _cc_pipeline
    container_op = factory_function(**operation.component_params_as_dict)
TypeError: My Component - 0.1.0() got an unexpected keyword argument 'my-input'

A Kubeflow component can name its inputs/outputs things that are not valid python kwargs names, in these cases, KFP silently renames these inputs by replacing the invalid characters with _.

• EXAMPLES:
  • my-input --> my_input
• Kubeflow Code:
  • https://github.com/kubeflow/pipelines/blob/1.8.1/sdk/python/kfp/components/_components.py#L359-L363
  • https://github.com/kubeflow/pipelines/blob/1.8.1/sdk/python/kfp/components/_naming.py#L32-L42
  • https://github.com/kubeflow/pipelines/blob/1.8.1/sdk/python/kfp/components/_naming.py#L49-L50

It is also possible to have a case where multiple different parameters map to the same "sanitized value". In these cases, KFP appends a number to the end of the ones which were transformed (starting at 2). But because elyra stores parameters in an unordered dictionary, we can't possibly know which one maps to which index. (But it's probably not a huge issue if we don't support this extreme edge case)

• EXAMPLES:
  • my-input and my_input --> my_input_2 and my_input
• Kubeflow Code:
  • https://github.com/kubeflow/pipelines/blob/1.8.1/sdk/python/kfp/components/_naming.py#L97-L122

How was this pull request tested?

I have tested this in a Kubeflow cluster with a component that has parameters named things like my-parameter-name, and they were correctly compiled and run.

---

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

[elyra-bot]

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link:

[ptitzler]

LGTM