Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for elyra-metadata 'create' and 'update' commands #2578

Merged
merged 5 commits into from
Mar 18, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Mar 17, 2022

Closes #2563.

Follow-up is required in Elyra version 4.0

What changes were proposed in this pull request?

  • Introduce new elyra-metadata create command
  • Introduce new elyra-metadata update command
  • Mark elyra-metadata install as deprecated
    • this can be observed, for example, by running elyra-metadata -h or elyra-metadata install <schemaspace-name> -h
  • Update documentation that references the deprecated elyra-metadata install command to use elyra-metadata create and elyra-metadata update instead
  • Add/update existing unit test cases
  • Replace elyra-metadata install with elyra-metadata create in all Dockerfiles
  • Update front-end tests that were using the elyra-metadata install command

With all changes in place there should be

  • no more elyra-metadata install strings in any files in this repository
  • no more --replace strings in any files in this repository, with the exception of metadata_app.py and test_metadata_app.py. The related source code will be removed in version 4.0.

The new unit test cases were derived from the existing elyra-metadata install test cases.

How was this pull request tested?

  • Added unit test cases for elyra-metadata create
  • Added unit test cases for elyra-metadata update
  • Reviewed the output of make docs
  • Manual testing

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:enhancement New feature or request component:cli-tools Command line tools labels Mar 17, 2022
@ptitzler ptitzler added this to the 3.7.0 milestone Mar 17, 2022
@elyra-bot
Copy link

elyra-bot bot commented Mar 17, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Mar 17, 2022
@ptitzler ptitzler added area:documentation Improvements or additions to documentation component:build build and build related issues(dependencies and docker) and removed status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. labels Mar 17, 2022
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good - thank you @ptitzler.

Could you please confirm that the create code is a direct copy of the previous install code with update_mode handling instead of --replace handling?

@ptitzler
Copy link
Member Author

These changes look good - thank you @ptitzler.

Could you please confirm that the create code is a direct copy of the previous install code with update_mode handling instead of --replace handling?

Yes, it is! The only changes are in __init__ and start. The other methods are identical.
Because SchemaspaceInstall is removed in 4.0, I didn't want to to through the extra effort to change it's implementation to inherit from SchemaspaceInstall.

@akchinSTC akchinSTC merged commit deb51ab into elyra-ai:master Mar 18, 2022
@ptitzler ptitzler deleted the deprecate-install branch March 21, 2022 15:08
kevin-bates pushed a commit to kevin-bates/elyra that referenced this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:documentation Improvements or additions to documentation component:build build and build related issues(dependencies and docker) component:cli-tools Command line tools kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata CLI: replace 'install' command with 'create' and 'update' commands
3 participants