-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for elyra-metadata 'create' and 'update' commands #2578
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good - thank you @ptitzler.
Could you please confirm that the create code is a direct copy of the previous install code with update_mode
handling instead of --replace
handling?
Yes, it is! The only changes are in |
Closes #2563.
Follow-up is required in Elyra version 4.0
elyra-metadata install
in https://github.com/elyra-ai/elyra/blob/master/elyra/metadata/metadata_app.py.test_install_*
unit tests in https://github.com/elyra-ai/elyra/blob/master/elyra/tests/metadata/test_metadata_app.pyWhat changes were proposed in this pull request?
elyra-metadata create
commandelyra-metadata update
commandelyra-metadata install
as deprecatedelyra-metadata -h
orelyra-metadata install <schemaspace-name> -h
elyra-metadata install
command to useelyra-metadata create
andelyra-metadata update
insteadelyra-metadata install
withelyra-metadata create
in allDockerfile
selyra-metadata install
commandWith all changes in place there should be
elyra-metadata install
strings in any files in this repository--replace
strings in any files in this repository, with the exception ofmetadata_app.py
andtest_metadata_app.py
. The related source code will be removed in version 4.0.The new unit test cases were derived from the existing
elyra-metadata install
test cases.How was this pull request tested?
elyra-metadata create
elyra-metadata update
make docs
Developer's Certificate of Origin 1.1