-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for metadata import in the CLI #2581
Add support for metadata import in the CLI #2581
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sandhya-nayak - I added a few initial comments but this looks good overall.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good @sandhya-nayak - thank you. Just had a couple more minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent stuff @sandhya-nayak - thank you!
I've completed my review/testing. If you make the suggested changes above to keep the code style consistent this PR should be good to go. |
Could you also update the heading in https://elyra.readthedocs.io/en/latest/user_guide/command-line-interface.html#list-create-update-export-and-delete-metadata to include 'import' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. LGTM! Thank you for helping us make our CLI story more compelling.
+1 |
What changes were proposed in this pull request?
Fixes #2500
Add support for metadata import in the cli
Add tests for import subcommand
Update documentation
How was this pull request tested?
Ran make clean, make install, make test, make docs to verify that the installation and tests were successful and documentation updates were rendered correctly.
Developer's Certificate of Origin 1.1