Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for metadata import in the CLI #2581

Merged
merged 12 commits into from
Apr 27, 2022

Conversation

sandhya-nayak
Copy link
Collaborator

@sandhya-nayak sandhya-nayak commented Mar 18, 2022

What changes were proposed in this pull request?

Fixes #2500

Add support for metadata import in the cli
Add tests for import subcommand
Update documentation

How was this pull request tested?

Ran make clean, make install, make test, make docs to verify that the installation and tests were successful and documentation updates were rendered correctly.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Mar 18, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC akchinSTC added status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. impact:do-not-merge labels Mar 18, 2022
@akchinSTC akchinSTC changed the title [WIP Do not merge] Cli metadata import Add support for metadata import in the CLI Mar 18, 2022
@ptitzler ptitzler added component:cli-tools Command line tools kind:enhancement New feature or request labels Mar 18, 2022
@ptitzler ptitzler added this to the 3.7.0 milestone Mar 18, 2022
@sandhya-nayak sandhya-nayak added impact:do-not-merge and removed status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. impact:do-not-merge labels Mar 18, 2022
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @sandhya-nayak - I added a few initial comments but this looks good overall.

elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good @sandhya-nayak - thank you. Just had a couple more minor comments.

elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
elyra/metadata/metadata_app.py Show resolved Hide resolved
elyra/metadata/metadata_app.py Outdated Show resolved Hide resolved
Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent stuff @sandhya-nayak - thank you!

@ptitzler
Copy link
Member

I've completed my review/testing. If you make the suggested changes above to keep the code style consistent this PR should be good to go.

@ptitzler
Copy link
Member

Could you also update the heading in https://elyra.readthedocs.io/en/latest/user_guide/command-line-interface.html#list-create-update-export-and-delete-metadata to include 'import'

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. LGTM! Thank you for helping us make our CLI story more compelling.

@akchinSTC
Copy link
Member

Very nice. LGTM! Thank you for helping us make our CLI story more compelling.

+1
This is awesome sandhya!

@akchinSTC akchinSTC merged commit 20c89ef into elyra-ai:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:cli-tools Command line tools kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLI: Add support for metadata import
4 participants