Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort generic component processing when prereq download fails #2630

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Apr 4, 2022

Fixes #2624

Example output for KFP when the user assigned an invalid value to environment variable ELYRA_REQUIREMENTS_URL:

image

Example output for Airflow when the user assigned an invalid value to environment variable ELYRA_REQUIREMENTS_URL:

image

What changes were proposed in this pull request?

  • When running generic nodes on KFP and Airflow, processing is aborted as soon as download of a prerequisite fails, preventing bootstrapper errors.
  • Log file to be downloaded, to simplify troubleshooting

Note: https://curl.se/docs/manpage.html#-f does not identify a version in which the option was introduced, which makes me believe that using it does not introduce a new restriction for a more current curl installation.

How was this pull request tested?

Confirmed that the log out yields the expected results when the user misconfigures environment variables ELYRA_REQUIREMENTS_URL, ELYRA_PIP_CONFIG_URL, ELYRA_GITHUB_ORG, orELYRA_GITHUB_BRANCH.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added the kind:bug Something isn't working label Apr 4, 2022
@ptitzler ptitzler added this to the 3.8.0 milestone Apr 4, 2022
@elyra-bot
Copy link

elyra-bot bot commented Apr 4, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added the status:Test in Progress Test creation or testing is still in progress. A PR tagged with this label is ready for review. label Apr 4, 2022
@ptitzler ptitzler added the status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. label Apr 4, 2022
@ptitzler

This comment was marked as resolved.

@ptitzler ptitzler added component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines and removed status:Work in Progress Development in progress. A PR tagged with this label is not review ready unless stated otherwise. status:Test in Progress Test creation or testing is still in progress. A PR tagged with this label is ready for review. labels Apr 4, 2022
@akchinSTC akchinSTC requested a review from lresende April 4, 2022 21:34
@akchinSTC akchinSTC merged commit b75a945 into elyra-ai:master Apr 5, 2022
@ptitzler ptitzler deleted the abort-on-download-fail branch April 5, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-runtime issues related to pipeline runtimes e.g. kubeflow pipelines kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KFP/Airflow generic component operators should propagate dependency download errors
3 participants