-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining references to airflow examples catalogs #2636
Remove remaining references to airflow examples catalogs #2636
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending the change in conftest.py
(which will temporarily break the CI tests until the PR is merged.
With the latest commit, there will be the following expected test failures/errors:
|
Confirmed! Other changes look good 👍 |
Closes #2422
What changes were proposed in this pull request?
This PR cleans up a few remaining items related to the
elyra-examples-airflow-catalog
that is now deprecated, including:elyra-examples-airflow-catalog
fromtest_requirements.txt
and insetup.py
test_requires
BashOperator
). Related changes include:bash_operator.py
to thetest/pipeline/resources/components
folderbash_operator.py
file hosted in the examples repo (seeconftest.py:39
) in order to show that tests are passing with this new url catalog. The url has been changes to the Elyra repo one in the latest commit, as this will be the 'permanent' reference (assuming we intend to eventually remove the Airflow examples content in the examples repo)test/pipeline/resources
to only refer to theBashOperator
component (whereas the examples catalog previously had 4 available components that were referenced in these pipelines)How was this pull request tested?
Tests are now passing with the changes mentioned above.
Developer's Certificate of Origin 1.1