Remove hacking dependency, capture version snapshot prior to CI testing #2671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes
hacking
from the set of test dependencies, as it was found to side-affect linting in server dev environments that were not seen during CI (see #2670 for details) and its absence doesn't appear to break anything.This change includes two other changes:
test_requirements.txt
as they're already included inlint_requirements.txt
.Version Snapshot
action has been added in thetest-server
job after dependencies have been installed and prior to running server tests. This equivalent information was inadvertently removed in CI Enhancements #1671.How was this pull request tested?
flake8
versions)make lint-server
- passesmake clean install
- passesmake test-dependencies lint-server
- passes (it was thislint-server
that failed withhacking
in place).Resolves: #2670
Developer's Certificate of Origin 1.1