Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hacking dependency, capture version snapshot prior to CI testing #2671

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

kevin-bates
Copy link
Member

This pull request removes hacking from the set of test dependencies, as it was found to side-affect linting in server dev environments that were not seen during CI (see #2670 for details) and its absence doesn't appear to break anything.

This change includes two other changes:

  1. The redundant lint-related dependencies have been removed from test_requirements.txt as they're already included in lint_requirements.txt.
  2. A Version Snapshot action has been added in the test-server job after dependencies have been installed and prior to running server tests. This equivalent information was inadvertently removed in CI Enhancements #1671.

How was this pull request tested?

  1. Per Test-dependencies side-affect linting in server development environments #2670, a new conda env was created.
  2. Then the branch for PR Add support for runtime image and env vars in pipeline default properties  #2656 was pulled (which contains the lining issue that surfaces using older flake8 versions)
  3. make lint-server - passes
  4. make clean install - passes
  5. make test-dependencies lint-server - passes (it was this lint-server that failed with hacking in place).

Resolves: #2670

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Apr 19, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working like a charm for me!

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and I'm no longer seeing the hacking library issues on my env!

@akchinSTC akchinSTC merged commit 70f3b58 into elyra-ai:master Apr 19, 2022
@kevin-bates kevin-bates deleted the remove-hacking-dependency branch April 19, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test-dependencies side-affect linting in server development environments
4 participants