Remove secret from airflow helm values #2677
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a scan to detect secrets persisted within the Elyra repository yielded several false positives, except one specifying a Fernet Key. Since the preceding comment describes how to generate a key value, it's fairly clear the value that is there should be replaced when a user deploys Elyra via the helm chart.
This pull request replaces the value with
"my-generated-fernetKey"
, which self-decribes what should be done, in conjunction with the preceding comment . That comment is captured here:Developer's Certificate of Origin 1.1