-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop Elyra against the Jupyterlab source repo #2709
Conversation
Adds documentation and some additions to the build scripts to allow Elyra developers to develope Elyra against a local build of Jupyterlab. Updates include: - Updated documentation with step by step instructions on how to step up the devlopment environment - Updating our `page_config.json` to the new format and location. We were previously using a deprecated format and location uncompatable with this feature. - Added a way to run `clean-jupyterlab.sh` without installing a new version of jupyterlab - Added new npm targets and make targets to leverage a yarn link version of `@jupyterlab/builder`. This was added to the existing support for `make dev-link`, but the order of make targets had to be rearranged to make sure lerna was installed before calling it. - Made a small backwards compatable change to fix a type conflict found when running against jupyterlab 4.0.0 alpha These changes are blocked by jupyterlab/jupyterlab#12533 without that change you also need to update the version of `@jupyterlab/builder` in every package.json to prevent an error
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
@kevin-bates is there any way to remove this dependency on ipython_genutils? elyra/elyra/metadata/metadata.py Line 22 in 720fb36
It causes issues in completely clean environments since lab no longer depends on it so we're no longer getting the import second hand. Also the readme for that library is literally just a "do not use this" message. I wasn't sure how to remove it since I don't quite understand what it's doing in our code. |
Yes, this dependency should be removed.
This package has been removed from several projects within the ecosystem. I didn't think to check we'd be using it but, well, we are.
The package, in general, provides utility methods mostly geared toward bridging the gap between python 2 and 3 codebases. However, there are some utilities that are just that, utilities. In this case, I should have a PR for this shortly. |
@karlaspuldaro I believe I've addressed all your documentation comments if you would like to take another look |
I also merged master to grab @kevin-bates fix in #2710 so this will also work on completely fresh conda envs as well now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! The steps to build Elyra against lab src repo work as expected.
In elyra-ai#2709 I removed jupyterlab from the build_requires.txt so that the local versaion of jupyterlab could be used if installed. This has caused frustration in users, so I've added the dependency back and update the make dev-install target to not use the dependency file at all, instead using a new make target to install the required dependency.
In #2709 I removed jupyterlab from the build_requires.txt so that the local versaion of jupyterlab could be used if installed. This has caused frustration in users, so I've added the dependency back and update the make dev-install target to not use the dependency file at all, instead using a new make target to install the required dependency.
Adds documentation and some additions to the build scripts to allow
Elyra developers to develope Elyra against a local build of
Jupyterlab.
Updates include:
step up the devlopment environment
page_config.json
to the new format and location.We were previously using a deprecated format and location
uncompatable with this feature.
clean-jupyterlab.sh
without installing a newversion of jupyterlab
version of
@jupyterlab/builder
. This was added to the existingsupport for
make dev-link
, but the order of make targets had tobe rearranged to make sure lerna was installed before calling it.
found when running against jupyterlab 4.0.0 alpha
These changes are blocked by
without that change you also need to update the version of
@jupyterlab/builder
in every package.json to prevent an errorDeveloper's Certificate of Origin 1.1