-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update generic component operator to support python 3.7 #2727
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting a failure after notebook execution in convert_notebook_to_html(notebook_output, notebook_html)
in the bootstrapper. import nbconvert
is causing errors (logs below).
Looks like the notebook executes fine though. And no issues at all with scripts.
Log Output
Executing: 100%|██████████| 2/2 [00:01<00:00, 1.55cell/s] [I 15:17:56.042] 'helloworld':'helloworld' - notebook execution completed (1.779 secs) [E 15:17:56.044] Unexpected error: Traceback (most recent call last): File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 356, in execute NotebookFileOp.convert_notebook_to_html(notebook_output, notebook_html) File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 377, in convert_notebook_to_html import nbconvert File "/usr/local/lib/python3.9/site-packages/nbconvert/__init__.py", line 4, in from .exporters import * File "/usr/local/lib/python3.9/site-packages/nbconvert/exporters/__init__.py", line 1, in from .base import (export, get_exporter, File "/usr/local/lib/python3.9/site-packages/nbconvert/exporters/base.py", line 14, in from ipython_genutils.py3compat import string_types ModuleNotFoundError: No module named 'ipython_genutils' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 697, in main() File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 687, in main file_op.execute() File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 364, in execute NotebookFileOp.convert_notebook_to_html(notebook_output, notebook_html) File "/var/lib/pandas/jupyter-work-dir/bootstrapper.py", line 377, in convert_notebook_to_html import nbconvert File "/usr/local/lib/python3.9/site-packages/nbconvert/__init__.py", line 4, in from .exporters import * File "/usr/local/lib/python3.9/site-packages/nbconvert/exporters/__init__.py", line 1, in from .base import (export, get_exporter, File "/usr/local/lib/python3.9/site-packages/nbconvert/exporters/base.py", line 14, in from ipython_genutils.py3compat import string_types ModuleNotFoundError: No module named 'ipython_genutils'
Potentially related to jupyter/nbconvert#1727 and its linked issue?
yeah, looks like we should bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working like a charm!
Shouldn't the same fix be applied to Airflow processing? |
Co-authored-by: Patrick Titzler <ptitzler@us.ibm.com>
Co-authored-by: Patrick Titzler <ptitzler@us.ibm.com>
Dependent on #2721
What changes were proposed in this pull request?
These changes update the KFP generic component and introduces a separate requirements file for runtime images that still use python 3.7 as this causes issues with dependency resolution during installation of ipython >= 8.
How was this pull request tested?
Developer's Certificate of Origin 1.1