Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipeline submit button reload bug #2734

Merged
merged 2 commits into from
May 23, 2022

Conversation

karlaspuldaro
Copy link
Member

@karlaspuldaro karlaspuldaro commented May 18, 2022

Fixes #2615

What changes were proposed in this pull request?

Fix logic to trigger ok dialog button on pressing enter key as default if form passes validation

How was this pull request tested?

Check that pressing enter key triggers ok button click on submit pipeline/file dialogs and export pipeline dialog.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented May 18, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler ptitzler added the kind:bug Something isn't working label May 19, 2022
@ptitzler ptitzler added this to the 3.9.0 milestone May 19, 2022
@ptitzler ptitzler added the component:pipeline-editor pipeline editor label May 19, 2022
Copy link
Member

@marthacryan marthacryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works as expected. Code LGTM. Thanks!

@akchinSTC akchinSTC self-requested a review May 23, 2022 15:26
@akchinSTC
Copy link
Member

LGTM

@lresende lresende merged commit c31164f into elyra-ai:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:pipeline-editor pipeline editor kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing enter triggers page reload in submit pipeline dialog
5 participants