Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag bug #2761

Merged
merged 4 commits into from
Jun 2, 2022
Merged

Fix tag bug #2761

merged 4 commits into from
Jun 2, 2022

Conversation

marthacryan
Copy link
Member

Fixes #2751. Cleans up metadata editor tag code to fix tag saving bug.

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jun 2, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@marthacryan marthacryan added the kind:bug Something isn't working label Jun 2, 2022
Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good to me!

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tags changes are now being saved as expected, thanks @marthacryan !
I just found a new bug in validating tags - adding empty space(s) tag through the UI cannot be removed and the metadata cannot be saved either.
Let me know if I should open a new issue for this.

@marthacryan
Copy link
Member Author

Thanks @kiersten-stokes and @karlaspuldaro for testing it out! @karlaspuldaro I added a fix for the empty spaces bug you found cause it was a quick fix.

Copy link
Member

@karlaspuldaro karlaspuldaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thx for also addressing the empty tag bug here!

@ptitzler ptitzler added this to the 3.9.0 milestone Jun 2, 2022
@ptitzler ptitzler added the component:metadata-editor Metadata Editor Extension label Jun 2, 2022
@akchinSTC akchinSTC merged commit 59e2230 into elyra-ai:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metadata-editor Metadata Editor Extension kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changes to metadata tags do not persist
5 participants