-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tag bug #2761
Fix tag bug #2761
Conversation
Thanks for making a pull request to Elyra! To try out this branch on binder, follow this link: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tags changes are now being saved as expected, thanks @marthacryan !
I just found a new bug in validating tags - adding empty space(s) tag through the UI cannot be removed and the metadata cannot be saved either.
Let me know if I should open a new issue for this.
Thanks @kiersten-stokes and @karlaspuldaro for testing it out! @karlaspuldaro I added a fix for the empty spaces bug you found cause it was a quick fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thx for also addressing the empty tag bug here!
Fixes #2751. Cleans up metadata editor tag code to fix tag saving bug.
Developer's Certificate of Origin 1.1