Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors to tag editor #2769

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Add errors to tag editor #2769

merged 3 commits into from
Jun 13, 2022

Conversation

marthacryan
Copy link
Member

This adds displaying errors to the tag editor. Uses the same css as all the other errors.
image

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@elyra-bot
Copy link

elyra-bot bot commented Jun 3, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@akchinSTC
Copy link
Member

hrmm is this a must have for 3.9?
wondering if we could somehow display a more helpful message for someone not familiar with regex.

@akchinSTC
Copy link
Member

if this is just to surface the fact that there is an error though, im ok with it

@marthacryan
Copy link
Member Author

@akchinSTC Yeah this isn't super readable but I'm just surfacing the error that rjsf created. It shouldn't actually be surfaced now that we're trimming it with #2768 - are there other cases that could break this pattern?

@akchinSTC akchinSTC added the component:metadata-editor Metadata Editor Extension label Jun 3, 2022
@akchinSTC akchinSTC added this to the 3.10.0 milestone Jun 3, 2022
@ptitzler
Copy link
Member

ptitzler commented Jun 10, 2022

@akchinSTC Yeah this isn't super readable but I'm just surfacing the error that rjsf created. It shouldn't actually be surfaced now that we're trimming it with #2768 - are there other cases that could break this pattern?

It doesn't look like it's working as intended. If a user enters a string with leading/trailing spaces the error message is surfaced:

image

In above example, I entered <space>werty and qwerty<space>. Is a rebase required?

Copy link
Member

@ptitzler ptitzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC akchinSTC merged commit 8620a1a into elyra-ai:main Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:metadata-editor Metadata Editor Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants