Clear all singleton instances during shutdown #2781
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2778
What changes were proposed in this pull request?
This PR clears all singleton variables (those always created during startup) during extension shutdown. Upstream tests that create a
ComponentCache
instance no longer side-affect their downstream tests that rely on the component cache being in a certain state. This solves the test failures related to the changes made betweenjupyter-server
1.17.0
and1.17.1
. The larger issue of what change(s) between those versions that now makes this necessary is still in question.How was this pull request tested?
Tests passing locally even with
jupyter-server==1.17.1
Developer's Certificate of Origin 1.1