Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all singleton instances during shutdown #2781

Merged
merged 3 commits into from
Jun 10, 2022

Conversation

kiersten-stokes
Copy link
Member

@kiersten-stokes kiersten-stokes commented Jun 9, 2022

Related to #2778

What changes were proposed in this pull request?

This PR clears all singleton variables (those always created during startup) during extension shutdown. Upstream tests that create a ComponentCache instance no longer side-affect their downstream tests that rely on the component cache being in a certain state. This solves the test failures related to the changes made between jupyter-server 1.17.0 and 1.17.1. The larger issue of what change(s) between those versions that now makes this necessary is still in question.

How was this pull request tested?

Tests passing locally even with jupyter-server==1.17.1

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@kiersten-stokes kiersten-stokes added the component:test Test-related label Jun 9, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jun 9, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@kevin-bates kevin-bates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and makes perfect sense. 1.17.1 has done some app cleanup that must have exposed the fact that we still had some singletons that were not cleared.

@ptitzler ptitzler added this to the 3.10.0 milestone Jun 10, 2022
@ptitzler ptitzler added the kind:bug Something isn't working label Jun 10, 2022
@akchinSTC akchinSTC merged commit 5d5b955 into elyra-ai:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:test Test-related kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants