Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication support to URL catalog connector #2804

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

ptitzler
Copy link
Member

@ptitzler ptitzler commented Jun 27, 2022

This PR adds

What changes were proposed in this pull request?

The URL catalog connector now accepts optional credentials and displays a placeholder URL.

image

  • If complete credentials (user id and password/API key) are provided, they are used to fetch every specified URL.
  • To use different credentials for different URLs, a user has to configure multiple URL connectors.

The URL connectors' log messages now indicate the name of the connector that is encountering the problem, i.e. if this connector is misconfigured

image

this error message might appear in the log:

Error. URL catalog connector 'count rows' is not configured properly. Authentication requires a user id and password or API key.

Existing URL component catalog connectors should continue to work as is, without the need for migration.

How was this pull request tested?

  • reviewed the output of make docs
  • tested the following scenarios:
    • no user id and password provided (should work for resources that allow for public access)
    • user id and password provided (should work for resources that require authentication)
    • user id provided, but no password (should fail - component is not listed in the VPE palette, error is logged in the JupyterLab console)
    • password provided, but no user id (should fail - component is not listed in the VPE palette, error is logged in the JupyterLab console)

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@ptitzler ptitzler added kind:enhancement New feature or request component:catalog connectors Access to component catalogs labels Jun 27, 2022
@ptitzler ptitzler added this to the 3.10.0 milestone Jun 27, 2022
@elyra-bot
Copy link

elyra-bot bot commented Jun 27, 2022

Thanks for making a pull request to Elyra!

To try out this branch on binder, follow this link: Binder

@ptitzler
Copy link
Member Author

The URL placeholder is looking good now. Thanks Martha!

Copy link
Member

@kiersten-stokes kiersten-stokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@akchinSTC
Copy link
Member

@ajbozarth -approved?

@akchinSTC akchinSTC merged commit a8aceaa into elyra-ai:main Jun 29, 2022
@ptitzler ptitzler deleted the url-auth branch July 7, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:catalog connectors Access to component catalogs kind:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add basic authentication support to URL connector
5 participants